Simplify certificate verifier usage #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eters * Instead it will be provided in to the trait implementation constructor. This greatly simplify the usage of the verifier since now the caller won't have to provide a certificate retriever to call the verifier methods to verify a certificate or a certificates chain. * Add a verify method to `ProtocolGenesisVerificationKey` this will eventually allow to remove the `ProtocolGenesisVerifier` as it was its only utility and it use a `ProtocolGenesisVerificationKey` internaly.
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
approved these changes
Oct 26, 2023
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR simplify the usage of the
CertificateVerifierby moving theCertificateRetrieverfrom its methods parameters to its the implementation.The goal is to allow to design a simple certificate verification api in the client.
Pre-submit checklist
Issue(s)
Relates to #1311